task: add optional commit hook #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
approved these changes
Mar 11, 2025
Collaborator
lovisaberggren
left a comment
lovisaberggren
left a comment
There was a problem hiding this comment.
Awesome, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
No more failed tests and missing formatting changes on your PR.
SLO for running commands is bellow 1s.
Proposed changes
Adding commit hook that runs only when JS files are changed
We can add the same for golang in follow up easing load on our CI/CD system and github fair usage policies.
How this works
Husky adds the automatic hook
All is optional and configured by running
npm run precommitDocumentation
Documentation provided as part of the contributing.md (introduced one as we going to add more details for IPA work going forward)
Manual Testing