task: Adding golang precommit hooks #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
tools/hooks/golang-precommit.sh
Outdated
Comment on lines
22
to
23
| # Return to the original directory | ||
| cd - |
Collaborator
There was a problem hiding this comment.
can we use pushd popd here please
tools/hooks/golang-precommit.sh
Outdated
|
|
||
| # Run unit tests for Go files | ||
| echo "Running Go unit tests..." | ||
| make unit-test |
Collaborator
There was a problem hiding this comment.
Since we have most of this in the cli makefile, can we have here
#!/usr/bin/env bash
pushd tools/cli
make pre-commit
so that we reuse the logic in the makefile in the cli
Member
Author
There was a problem hiding this comment.
Awesome! I missed that precommit setup!
andreaangiolillo
approved these changes
Mar 11, 2025
Collaborator
andreaangiolillo
left a comment
andreaangiolillo
left a comment
There was a problem hiding this comment.
LGTM, thanks for all the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding specific golang precommit hooks to help with streamlining PR creation.
Changes are only run when go file change is detected in changeset.