DOP-1129: Handle additional ordered list types #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i80and
reviewed
Jun 23, 2020
CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - fail_on_diagnostics toml flag (DOP-1132) | ||
| - Support additional ordered list labels |
Contributor
There was a problem hiding this comment.
Optionally include the ticket number here!!
snooty/parser.py
Outdated
| self.state.append(n.ListNode((line,), [], n.ListEnumType.unordered)) | ||
| elif isinstance(node, docutils.nodes.enumerated_list): | ||
| self.state.append(n.ListNode((line,), [], True)) | ||
| self.state.append(n.ListNode((line,), [], node["enumtype"])) |
Contributor
There was a problem hiding this comment.
Is this valid? Isn't this passing a string where ListEnumType is expected? Do we need to use n.ListEnumType[node["enumtype"]]?
i80and
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JIRA] Add support for all ordered list types supported by rST.