Skip to content

DOP-2778: Fix side nav items with children so they collapse on click#565

Merged
gjchong25 merged 3 commits into
masterfrom
DOP-2778
Feb 25, 2022
Merged

DOP-2778: Fix side nav items with children so they collapse on click#565
gjchong25 merged 3 commits into
masterfrom
DOP-2778

Conversation

@gjchong25
Copy link
Copy Markdown
Contributor

@gjchong25 gjchong25 commented Feb 24, 2022

Stories/Links:

DOP-2778

Staging Links:

Realm Staging

Notes:

allisonmui9
allisonmui9 approved these changes Feb 24, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@allisonmui9 allisonmui9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so speedy. very nice lgtm thank you!

@gjchong25 gjchong25 requested a review from rayangler February 24, 2022 19:54
rayangler
rayangler reviewed Feb 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rayangler rayangler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but I wanted to bring up that if you scroll down a page that has nested pages (example: Tutorial), and then click on the side nav item that corresponds to that same page to close the nested items, you end up back at the top of the page (but the side nav item closes successfully!).

Is this interaction okay? @allisonmui9

@allisonmui9
Copy link
Copy Markdown
Collaborator

allisonmui9 commented Feb 25, 2022

Tutorial

Oooooo .... Raymund good catch. Honestly, I'm not sure how we should address it. It's in production now, but I haven't heard any feedback regarding the behavior. I'm okay with leaving it as is and monitoring for any feedback in the future!

Thanks :)

rayangler
rayangler approved these changes Feb 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that sounds good to me. Thanks @allisonmui9 and @gjchong25 !

LGTM!

@gjchong25 gjchong25 merged commit fd211f3 into master Feb 25, 2022
@gjchong25 gjchong25 deleted the DOP-2778 branch February 25, 2022 20:44
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
@gjchong25
DOP-2778: Fix side nav items with children so they collapse on click (#…
ee3ae85 
…565)

* DOP-2778: Fix side nav items so that they collapse on second click

* add test

Co-authored-by: Grace Chong <grace.chong@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allisonmui9 allisonmui9 allisonmui9 approved these changes

+1 more reviewer

@rayangler rayangler rayangler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gjchong25 @allisonmui9 @rayangler