DRIVERS-3095: Use extjson Infinity representation in float32 vector test #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
ghost
mentioned this pull request
matthewdale
approved these changes
Mar 10, 2025
Contributor
matthewdale
left a comment
matthewdale
left a comment
There was a problem hiding this comment.
Confirmed unmarshaling this as Extended JSON works with the Go Driver: https://goplay.tools/snippet/Row1gYuokbl
Looks good! 👍
Author
|
Thanks for the review! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal change to address DRIVERS-3095. The "inf" and "-inf" strings are replaced with extjson double Infinity and -Infinity. No other changes are made. Drivers may not require any changes, if their comparison code is already safe to use with non-finite double inputs. Drivers may be able to remove workarounds.
Test these changes against all server versions and topologies (including standalone, replica set, sharded(Not applicable, BSON change only.)clusters, and serverless).