DRIVERS-3480 Clarify that the operationTime MUST save rule excludes unacknowledged writes#1938
Open
GromNaN wants to merge 1 commit into
Open
Conversation
The general rule stated drivers "MUST save the operationTime whether the operation succeeded or not", while the "Unacknowledged writes" section stated the operationTime is not updated because no response is received. These appeared contradictory. Clarify that the MUST applies only to acknowledged operations, and add a cross-reference to the Unacknowledged writes section explaining why.
GromNaN
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/DRIVERS-3480
The implementation section stated:
The "Unacknowledged writes" section then stated:
These two requirements directly contradict each other: saving
operationTimerequires a server response, but unacknowledged writes produce none.The fix adds "acknowledged" to the general rule and adds a cross-reference to the Unacknowledged writes section, making clear the exception applies there.
No behaviour change intended.