STITCH-2008 - JS location metadata lookup, unit tests to follow #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchel
approved these changes
Nov 28, 2018
Contributor
adamchel
left a comment
adamchel
left a comment
There was a problem hiding this comment.
nice work! LGTM mod some styles and nits
jsflax
approved these changes
Nov 29, 2018
Contributor
jsflax
left a comment
jsflax
left a comment
There was a problem hiding this comment.
LGTM barring Adam's comments
…tch request client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Javascript SDK implementation of the logic for multi-region hostname lookup. Upon the first call to the client API, rather than directly accessing the underlying service, the SDK will now first await the result of a lookup to /client/v2/app/:clientAppId/location and use the hostname specified in the result as the hostname for the user request.
Differs slightly from the other SDKs in that it relies on failed promises rather than explicit error catching logic in the case of failure to retrieve or parse the location metadata.