STITCH-2240 - Unify toArray/asArray syntax between Functions and SDKs

packages/browser/services/mongodb-remote/__tests__/RemoteMongoClientIntTests.ts

@@ -170,16 +170,16 @@ describe("RemoteMongoClient", () => {
     );
 
     let count = 0;
-    (await coll.find().asArray()).forEach(_ => {
+    (await coll.find().toArray()).forEach(_ => {
       count++;
     });
     expect(2).toEqual(count);
 
     expect(
-      (await coll.find().asArray()).find(it => doc1.hello === it.hello)
+      (await coll.find().toArray()).find(it => doc1.hello === it.hello)
     ).toBeDefined();
 
-    expect([doc1, doc2]).toEqual(await coll.find().asArray());
+    expect([doc1, doc2]).toEqual(await coll.find().toArray());
 
     const asyncIter = await iter.iterator();
     expect(doc1).toEqual(await asyncIter.next());
@@ -268,7 +268,7 @@ describe("RemoteMongoClient", () => {
 
     await coll.insertMany([doc3, doc4]);
     expect(withoutIds([doc1, doc2, doc3, doc4])).toEqual(
-      withoutIds(await coll.find().asArray())
+      withoutIds(await coll.find().toArray())
     );
   });
 
@@ -384,7 +384,7 @@ describe("RemoteMongoClient", () => {
     expectedDoc1.woof = "meow";
     const expectedDoc2 = { woof: "meow" };
     expect([expectedDoc1, expectedDoc2]).toEqual(
-      withoutIds(await coll.find({}).asArray())
+      withoutIds(await coll.find({}).toArray())
     );
 
     try {

packages/browser/services/mongodb-remote/src/RemoteMongoReadOperation.ts

@@ -36,8 +36,16 @@ export default class RemoteMongoReadOperation<T> {
   /**
    * Executes the operation and returns the result as an array.
    */
+  public toArray(): Promise<T[]> {
+    return this.proxy.toArray();
+  }
+
+  /**
+   * Executes the operation and returns the result as an array.
+   * @deprecated Use toArray instead
+   */
   public asArray(): Promise<T[]> {
-    return this.proxy.asArray();
+    return this.toArray();
   }
 
   /**

packages/core/services/mongodb-remote/src/internal/CoreRemoteMongoReadOperation.ts

@@ -47,10 +47,14 @@ export default class CoreRemoteMongoReadOperation<T> {
     return this.executeRead().then(res => res[0]);
   }
 
-  public asArray(): Promise<T[]> {
+  public toArray(): Promise<T[]> {
     return this.executeRead();
   }
 
+  public asArray(): Promise<T[]> {
+    return this.toArray();
+  }
+
   private executeRead(): Promise<T[]> {
     return this.service.callFunction(
       this.command,

packages/react-native/services/mongodb-remote/__tests__/RemoteMongoClientIntTests.ts

@@ -170,16 +170,16 @@ describe("RemoteMongoClient", () => {
     );
 
     let count = 0;
-    (await coll.find().asArray()).forEach(_ => {
+    (await coll.find().toArray()).forEach(_ => {
       count++;
     });
     expect(2).toEqual(count);
 
     expect(
-      (await coll.find().asArray()).find(it => doc1.hello === it.hello)
+      (await coll.find().toArray()).find(it => doc1.hello === it.hello)
     ).toBeDefined();
 
-    expect([doc1, doc2]).toEqual(await coll.find().asArray());
+    expect([doc1, doc2]).toEqual(await coll.find().toArray());
 
     const asyncIter = await iter.iterator();
     expect(doc1).toEqual(await asyncIter.next());
@@ -268,7 +268,7 @@ describe("RemoteMongoClient", () => {
 
     await coll.insertMany([doc3, doc4]);
     expect(withoutIds([doc1, doc2, doc3, doc4])).toEqual(
-      withoutIds(await coll.find().asArray())
+      withoutIds(await coll.find().toArray())
     );
   });
 
@@ -384,7 +384,7 @@ describe("RemoteMongoClient", () => {
     expectedDoc1.woof = "meow";
     const expectedDoc2 = { woof: "meow" };
     expect([expectedDoc1, expectedDoc2]).toEqual(
-      withoutIds(await coll.find({}).asArray())
+      withoutIds(await coll.find({}).toArray())
     );
 
     try {

packages/react-native/services/mongodb-remote/src/RemoteMongoReadOperation.ts

@@ -36,8 +36,16 @@ export default class RemoteMongoReadOperation<T> {
   /**
    * Executes the operation and returns the result as an array.
    */
+  public toArray(): Promise<T[]> {
+    return this.proxy.toArray();
+  }
+
+  /**
+   * Executes the operation and returns the result as an array.
+   * @deprecated Use toArray instead
+   */
   public asArray(): Promise<T[]> {
-    return this.proxy.asArray();
+    return this.toArray();
   }
 
   /**

packages/server/services/mongodb-remote/__tests__/RemoteMongoClientIntTests.ts

@@ -170,16 +170,16 @@ describe("RemoteMongoClient", () => {
     );
 
     let count = 0;
-    (await coll.find().asArray()).forEach(_ => {
+    (await coll.find().toArray()).forEach(_ => {
       count++;
     });
     expect(2).toEqual(count);
 
     expect(
-      (await coll.find().asArray()).find(it => doc1.hello === it.hello)
+      (await coll.find().toArray()).find(it => doc1.hello === it.hello)
     ).toBeDefined();
 
-    expect([doc1, doc2]).toEqual(await coll.find().asArray());
+    expect([doc1, doc2]).toEqual(await coll.find().toArray());
 
     const asyncIter = await iter.iterator();
     expect(doc1).toEqual(await asyncIter.next());
@@ -268,7 +268,7 @@ describe("RemoteMongoClient", () => {
 
     await coll.insertMany([doc3, doc4]);
     expect(withoutIds([doc1, doc2, doc3, doc4])).toEqual(
-      withoutIds(await coll.find().asArray())
+      withoutIds(await coll.find().toArray())
     );
   });
 
@@ -384,7 +384,7 @@ describe("RemoteMongoClient", () => {
     expectedDoc1.woof = "meow";
     const expectedDoc2 = { woof: "meow" };
     expect([expectedDoc1, expectedDoc2]).toEqual(
-      withoutIds(await coll.find({}).asArray())
+      withoutIds(await coll.find({}).toArray())
     );
 
     try {

packages/server/services/mongodb-remote/src/RemoteMongoReadOperation.ts

@@ -36,8 +36,16 @@ export default class RemoteMongoReadOperation<T> {
   /**
    * Executes the operation and returns the result as an array.
    */
+  public toArray(): Promise<T[]> {
+    return this.proxy.toArray();
+  }
+
+  /**
+   * Executes the operation and returns the result as an array.
+   * @deprecated Use toArray instead
+   */
   public asArray(): Promise<T[]> {
-    return this.proxy.asArray();
+    return this.toArray();
   }
 
   /**