STITCH-2485 New StitchAuthListener interface #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkaye407
approved these changes
Feb 11, 2019
Contributor
tkaye407
left a comment
tkaye407
left a comment
There was a problem hiding this comment.
LGTM. Curious what your thoughts are on not actually having onAuthEventI() in the auth methods like swtich() and login() but rather whenever a switch() or a login() event "kind" come in you issue a legacy auth event as well? Could be done in dispatchAuthEvent()
jsflax
approved these changes
Feb 12, 2019
Contributor
jsflax
left a comment
jsflax
left a comment
There was a problem hiding this comment.
LGTM bar a couple style nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically adds new methods to the
StitchAuthListenerinterface, enriching its use cases.About 1,000 of the lines of code here are 300 lines of integration tests, copied across the three SDKs. The integration tests are pretty much the same across the platforms so it's probably worth it to only just look through one of the integration test files.