Skip to content

Conversation

@cbush
Copy link
Contributor

@cbush cbush commented Feb 14, 2019

@cbush cbush requested a review from MongoCaleb February 14, 2019 17:15
Copy link

@MongoCaleb MongoCaleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cbush cbush force-pushed the docsp-3938-style-theme branch from 893f89e to df094df Compare February 14, 2019 18:03
@coveralls
Copy link

coveralls commented Feb 14, 2019

Coverage Status

Coverage remained the same at 77.329% when pulling befb324 on cbush:docsp-3938-style-theme into 05e0548 on mongodb:master.

margin: 0 -20px 10px -20px
padding: 0 20px 10px 20px
border-bottom: 1px solid $COLOR_PANEL_DIVIDER
// border-bottom: 1px solid $COLOR_PANEL_DIVIDER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] remove comment

padding: 20px 0
background-color: $COLOR_PANEL
box-shadow: 0 0 4px rgba(#000, 0.25)
// box-shadow: 0 0 4px rgba(#000, 0.25)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] remove comment

margin: 0 0 40px 0
background: $COLOR_PANEL
box-shadow: 0 0 5px rgba(#000, 0.35)
// box-shadow: 0 0 5px rgba(#000, 0.35)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] remove comment

- Most styling based on docs-tools/themes/mongodb
- Adds signature Akzidenz font
- Code blocks now look like they do on the main docs site
(TODO: add 'copy to clipboard' feature: https://jira.mongodb.org/browse/DOCSP-4525)
@cbush cbush force-pushed the docsp-3938-style-theme branch from befb324 to d083e26 Compare February 15, 2019 16:13
@cbush cbush merged commit 496add5 into mongodb:master Feb 15, 2019
@cbush cbush deleted the docsp-3938-style-theme branch February 15, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants