Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Redesigns the Models “table” view projection UX to be inline (projection text input + add/remove columns) and persists projection selections per model, along with associated layout/styling updates.
Changes:
- Add per-model projection persistence and new projection manipulation methods (add/remove/reset/all, parse projection input).
- Replace the old projection modal/table header UI with an inline projection bar + add-field dropdown.
- Refactor layout/CSS for the table/json views and the documents header area.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| frontend/src/models/models.js | Adds projection persistence/parsing and new projection UI state/handlers; updates URL sync behavior. |
| frontend/src/models/models.html | Replaces projection modal with inline projection controls and add-field dropdown; adjusts table/json rendering. |
| frontend/src/models/models.css | Introduces new projection/table/dropdown styling and layout changes for documents area. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vkarpov15
left a comment
vkarpov15
left a comment
There was a problem hiding this comment.
The overflow behavior on this table needs some work: Horizontal scrollbar doesn't show up for large data sets because you can't scroll to the bottom (video 1)
Screencast.from.2026-02-25.21-34-58.mp4
Also the "copy" tooltip for individual fields gets clipped by overflow: hidden:
|
Oh and 1 more thing: also need projections for the JSON view |
|
The merge from main undid a lot and the feedback here indicates that another swing needs to be taken so its just better to open a new PR at this point |
|
Scratch that, its because of how it looks without a workspace |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Also, I thought I had. I think its worth considering that the table view should only support projections so you have one view that shows data concisely and one view that shows everything so you don't have to go back and forth with the projection or one of the fields is a bit messy (array, embed, mixed) so you wouldn't really be able to view that in the table view anyway |
vkarpov15
left a comment
vkarpov15
left a comment
There was a problem hiding this comment.
Overall this is really good I just had a couple of minor things to patch up. Also right now when you click "select" there's no indication of which fields are selected.
Screencast.from.2026-03-22.22-21-12.mp4
…sejs/studio into IslandRhythms/projection-redesign
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 18 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sejs/studio into IslandRhythms/projection-redesign
No description provided.