correct TypeScript params for creating express router#226
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c783b7fb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,7 +1,12 @@ | |||
| declare module '@mongoosejs/studio' { | |||
| import { RequestHandler } from 'express'; | |||
| import mongoose from 'mongoose'; | |||
There was a problem hiding this comment.
Avoid default-importing mongoose in .d.ts
mongoose is typed as an export = module, so default-importing it in a declaration file (import mongoose from 'mongoose') causes TS1259 in projects that compile with esModuleInterop/allowSyntheticDefaultImports disabled and skipLibCheck off. In that setup, simply consuming @mongoosejs/studio breaks type-checking. Please switch to an import = require(...) form or equivalent type-only imports compatible with export = modules.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.