Skip to content

[codex] Complete spec 018 boot failure visibility#1262

Merged
zbigniewsobiecki merged 3 commits intodevfrom
plan/018-2-boot-failure-visibility
May 6, 2026
Merged

[codex] Complete spec 018 boot failure visibility#1262
zbigniewsobiecki merged 3 commits intodevfrom
plan/018-2-boot-failure-visibility

Conversation

@zbigniewsobiecki
Copy link
Copy Markdown
Member

Summary

  • Create agent_runs rows before boot-phase plan resolution and use a typed BootFailureError boundary for run-record, definition-lookup, and plan-resolution failures.
  • Mark boot failures as failed runs, capture them to Sentry under worker_boot_failure, rethrow so workers exit 2, and label exit 2 as Worker boot failed in router crash diagnostics.
  • Add stable synthesized Sentry work item IDs, prompt-template conformance coverage, direct DB integration coverage for deferred plan fields, and docs/changelog updates for spec 018 completion.

Verification

  • npm run lint
  • npm run typecheck
  • npm test — 481 files, 8831 passed, 23 skipped
  • npm run test:integration — 31 files, 552 passed
  • Pre-push npm run test:fast -- --changed origin/dev via lefthook — 175 files, 3556 passed, 23 skipped

Notes

  • Spec 018 post-deploy 24h log-volume observation remains explicitly documented as deferred until this lands on dev and sees normal production traffic.

zbigniewsobiecki and others added 2 commits May 6, 2026 14:21
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@zbigniewsobiecki zbigniewsobiecki marked this pull request as ready for review May 6, 2026 15:34
@zbigniewsobiecki zbigniewsobiecki requested a review from aaight May 6, 2026 15:35
@nhopeatall
Copy link
Copy Markdown
Collaborator

nhopeatall commented May 6, 2026

⚠️ review agent failed

Your access token could not be refreshed because your refresh token was already used. Please log out and sign in again.

Manual intervention may be required.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 91.42857% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/db/repositories/runsRepository.ts 0.00% 8 Missing ⚠️
src/agents/shared/bootFailureError.ts 90.90% 1 Missing and 1 partial ⚠️
src/agents/shared/executionPipeline.ts 94.28% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@zbigniewsobiecki zbigniewsobiecki merged commit 19fb114 into dev May 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants