Skip to content

test(triggers): characterize agent execution pipeline#1265

Merged
aaight merged 1 commit into
devfrom
test/agent-execution-characterization
May 8, 2026
Merged

test(triggers): characterize agent execution pipeline#1265
aaight merged 1 commit into
devfrom
test/agent-execution-characterization

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented May 8, 2026

Summary

Adds facade-level characterization coverage for runAgentExecutionPipeline before production helper extraction.

Card: https://trello.com/c/69fdedb3941d8fafe8cf4bb1

Changes

  • Pins the missing-agentType guard so the lifecycle, validation, and agent runner are not invoked for non-dispatchable trigger results.
  • Covers integration-validation failure behavior, including PM failure notification when PM validation is usable, PM-notification skip when PM validation failed, and onFailure callback invocation.
  • Adds best-effort persistence coverage showing work-item row failures do not prevent agent execution.
  • Pins callback ordering for onSuccess and onFailure after agent execution and post-run lifecycle handling.
  • Adds facade coverage for lifecycle skip flags around prepare/cleanup/failure/success handling.

Tests

  • npx vitest run --project unit-triggers tests/unit/triggers/shared/agent-execution.test.ts tests/unit/triggers/agent-execution.test.ts
  • npm run lint:fix
  • npm run lint
  • npm run typecheck
  • npm test

🕵️ codex · gpt-5.5 · run details

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the PR is test-only, keeps production code unchanged, and adds facade-level characterization coverage for the requested agent execution pipeline branches. Targeted trigger tests pass locally, and CI is green.

🕵️ codex · gpt-5.5 · run details

@aaight aaight merged commit be7236b into dev May 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants