feat(pm): add friction slot accessors#1294
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
May 9, 2026
Collaborator
nhopeatall
left a comment
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - the new friction accessors match the work item contract and mirror the existing alerts-slot semantics across Trello, JIRA, and Linear. The optional schema contract is documented, focused coverage is present, and CI is green.
🕵️ codex · gpt-5.5 · run details
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the provider-neutral PM
frictionslot contract requested by https://trello.com/c/69ff6a27f1ffa38b6e5f2cbc.Changes
getFrictionContainerId(project)for Trello, JIRA, and Linear with the same guarded container semantics as the alerts slot.getFrictionStatusDestination(project)for provider-native friction destinations.frictionas a recognized optional Trello list key and JIRA/Linear status key in provider config schema comments.Testing
npx vitest run --project unit-core tests/unit/pm/config-friction-slot.test.ts tests/unit/pm/config-alert-accessors.test.ts tests/unit/pm/config-alert-slot.test.tsnpm run lint:fixnpm run lintnpm run typecheckNote:
npm run lintpasses with existing unrelated warnings intests/unit/backends/postProcess.test.tsandtests/unit/gadgets/github/core/createPR.test.ts.🕵️ codex · gpt-5.5 · run details