feat(pm-wizard): add provider-owned credential metadata#1303
Merged
Conversation
nhopeatall
approved these changes
May 10, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - the provider-owned metadata matches the existing auth and persistence contracts, the current call paths remain compatibility-safe, and CI is green.
🕵️ codex · gpt-5.5 · run details
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds provider-owned auth and credential persistence metadata to the frontend PM wizard definition path. This is a compatibility-first foundation: existing save and verification call paths remain unchanged, while metadata-backed helpers and tests prove the contract for the next refactor.
Card: https://trello.com/c/6a003177cc0f09c06dca1b2e
Changes
ProviderWizardDefinitionwith typed auth metadata for raw credentials and stored project credential fallback.ProviderWizardDefinitionwith typed normal credential persistence metadata.api_key+tokenandTRELLO_API_KEY+TRELLO_TOKEN.email,api_token, andbase_url, while persisting onlyJIRA_EMAILandJIRA_API_TOKEN.api_keyandLINEAR_API_KEY; webhook secret persistence remains managed by the Linear webhook step.Verification
npx vitest run --project unit-core tests/unit/web/pm-wizard-hooks.test.ts tests/unit/web/pm-provider-registry.test.ts tests/unit/web/pm-wizard-generic-renderer.test.tsnpm run typechecknpm run lint:fixnpm run lintenv -u CASCADE_ORG_ID npm testNote: plain
npm testinitially failed because this agent environment exportsCASCADE_ORG_ID=mongrel, which leaks intotests/unit/cli/dashboard/config.test.ts; rerunning with that env var unset passed all unit tests.🕵️ codex · gpt-5.5 · run details