Skip to content

feat(pm-wizard): add provider-owned credential metadata#1303

Merged
aaight merged 1 commit into
devfrom
feature/pm-provider-wizard-credential-metadata
May 10, 2026
Merged

feat(pm-wizard): add provider-owned credential metadata#1303
aaight merged 1 commit into
devfrom
feature/pm-provider-wizard-credential-metadata

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented May 10, 2026

Summary

Adds provider-owned auth and credential persistence metadata to the frontend PM wizard definition path. This is a compatibility-first foundation: existing save and verification call paths remain unchanged, while metadata-backed helpers and tests prove the contract for the next refactor.

Card: https://trello.com/c/6a003177cc0f09c06dca1b2e

Changes

  • Extends ProviderWizardDefinition with typed auth metadata for raw credentials and stored project credential fallback.
  • Extends ProviderWizardDefinition with typed normal credential persistence metadata.
  • Declares Trello auth/persistence metadata for api_key + token and TRELLO_API_KEY + TRELLO_TOKEN.
  • Declares JIRA auth metadata for email, api_token, and base_url, while persisting only JIRA_EMAIL and JIRA_API_TOKEN.
  • Declares Linear auth/persistence metadata for api_key and LINEAR_API_KEY; webhook secret persistence remains managed by the Linear webhook step.
  • Adds metadata-backed auth payload tests covering stored credential fallback, raw credential payloads, missing credential errors, and provider metadata completeness.

Verification

  • npx vitest run --project unit-core tests/unit/web/pm-wizard-hooks.test.ts tests/unit/web/pm-provider-registry.test.ts tests/unit/web/pm-wizard-generic-renderer.test.ts
  • npm run typecheck
  • npm run lint:fix
  • npm run lint
  • env -u CASCADE_ORG_ID npm test

Note: plain npm test initially failed because this agent environment exports CASCADE_ORG_ID=mongrel, which leaks into tests/unit/cli/dashboard/config.test.ts; rerunning with that env var unset passed all unit tests.

🕵️ codex · gpt-5.5 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the provider-owned metadata matches the existing auth and persistence contracts, the current call paths remain compatibility-safe, and CI is green.

🕵️ codex · gpt-5.5 · run details

@aaight aaight merged commit 0241783 into dev May 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants