Skip to content

feat(web): drive PM provider picker from registry#1316

Merged
aaight merged 1 commit into
devfrom
feature/pm-provider-picker-registry
May 10, 2026
Merged

feat(web): drive PM provider picker from registry#1316
aaight merged 1 commit into
devfrom
feature/pm-provider-picker-registry

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented May 10, 2026

Summary

Implements the registry-driven PM provider picker for the dashboard wizard.

Card: https://trello.com/c/6a004d924258a2f6ab68dd74

Changes

  • Extracted the provider picker into ProviderPicker, rendered from listProviderWizards() so any registered provider appears without editing the picker loop.
  • Kept provider switching behavior intact while moving confirmation copy through a label-based message builder using provider definition labels.
  • Updated stale registry comments now that the manifest path is mandatory.
  • Reworked focused unit coverage to register a non-production stub provider and verify it renders in the picker.

Verification

  • npx vitest run --project unit-core tests/unit/web/pm-provider-registry.test.ts tests/unit/web/pm-wizard-generic-renderer.test.ts
  • npm run lint:fix
  • npm run lint
  • npm run typecheck
  • cd web && npm run build
  • npm test

Notes

  • npm run lint passes with existing warning-level complexity/non-null assertion diagnostics outside this change set.

🕵️ codex · gpt-5.5 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the provider picker is registry-driven, uses provider definition labels for switch confirmation, and the existing provider switch/reset/save cleanup behavior is preserved. Focused unit tests passed locally, and CI is green.

🕵️ codex · gpt-5.5 · run details

@aaight aaight merged commit 2811437 into dev May 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants