Skip to content

fix(trello): send card text updates in request body#1317

Merged
aaight merged 1 commit into
devfrom
fix/trello-update-card-body
May 10, 2026
Merged

fix(trello): send card text updates in request body#1317
aaight merged 1 commit into
devfrom
fix/trello-update-card-body

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented May 10, 2026

Summary

Fixes Trello card title/description updates so mutable card text is sent in a JSON request body instead of through the trello.js update path that can place long descriptions in the URL.

Card: https://trello.com/c/6a004c640c9f21691d4d0e64

Changes

  • Routes trelloClient.updateCard() through the existing authenticated trelloFetch() helper with PUT /cards/{id} and Content-Type: application/json.
  • Builds the update body with name and desc only when they are explicitly provided, preserving desc: "" for clearing descriptions.
  • Updates Trello client tests to assert long descriptions are present in RequestInit.body and absent from the URL.

Validation

  • npx vitest run --project unit-core tests/unit/trello/client.test.ts tests/unit/pm/trello/adapter.test.ts tests/unit/gadgets/pm/core/updateWorkItem.test.ts tests/unit/cli/file-input-flags.test.ts
  • npm run lint:fix
  • npm run lint
  • npm run typecheck
  • npm test

Docs

No docs update needed; the public cascade-tools pm update-work-item --description-file contract is unchanged.

🕵️ codex · gpt-5.5 · run details

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - The Trello card update path now uses the existing authenticated JSON-body helper, keeps mutable card text out of the URL, and the focused Trello client regression test passes locally.

🕵️ codex · gpt-5.5 · run details

@aaight aaight merged commit d4d9e34 into dev May 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants