fix(trello): send card text updates in request body#1317
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
May 10, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - The Trello card update path now uses the existing authenticated JSON-body helper, keeps mutable card text out of the URL, and the focused Trello client regression test passes locally.
🕵️ codex · gpt-5.5 · run details
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Trello card title/description updates so mutable card text is sent in a JSON request body instead of through the trello.js update path that can place long descriptions in the URL.
Card: https://trello.com/c/6a004c640c9f21691d4d0e64
Changes
trelloClient.updateCard()through the existing authenticatedtrelloFetch()helper withPUT /cards/{id}andContent-Type: application/json.nameanddesconly when they are explicitly provided, preservingdesc: ""for clearing descriptions.RequestInit.bodyand absent from the URL.Validation
npx vitest run --project unit-core tests/unit/trello/client.test.ts tests/unit/pm/trello/adapter.test.ts tests/unit/gadgets/pm/core/updateWorkItem.test.ts tests/unit/cli/file-input-flags.test.tsnpm run lint:fixnpm run lintnpm run typechecknpm testDocs
No docs update needed; the public
cascade-tools pm update-work-item --description-filecontract is unchanged.🕵️ codex · gpt-5.5 · run details