feat(pm-wizard): move edit hydration into provider definitions#1320
Merged
Conversation
nhopeatall
approved these changes
May 10, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - provider-owned edit hydration preserves the existing Trello, JIRA, and Linear edit-state behavior, and the registry-backed unknown-provider path is covered. Focused unit tests passed locally: npm test -- --run tests/unit/web/pm-wizard-state.test.ts tests/unit/web/pm-wizard-generic-renderer.test.ts tests/unit/web/pm-provider-registry.test.ts.
🕵️ codex · gpt-5.5 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Card: https://trello.com/c/6a004dc1c8cdf68fbae5dc4b
Moves PM wizard edit-mode hydration out of shared provider-branching state code and into each provider wizard definition.
PMWizardnow resolves the saved provider through the registered provider wizard before hydrating edit state, so unknown providers fail explicitly instead of returning a partial shared state.Changes
ProviderWizardDefinition.buildEditState(initialConfig, configuredKeys)for provider-owned edit hydration.buildEditStateimplementation frompm-wizard-state.ts.Verification
npm test -- --run tests/unit/web/pm-wizard-state.test.ts tests/unit/web/pm-wizard-generic-renderer.test.ts tests/unit/web/pm-provider-registry.test.tsnpm run lint:fixnpm run lintnpm run typechecknpm testnpm run test:integrationNote:
npm run lintexits 0 and still reports existing warning-level findings outside this change.🕵️ codex · gpt-5.5 · run details