Skip to content

feat(pm-wizard): move edit hydration into provider definitions#1320

Merged
aaight merged 1 commit into
devfrom
feature/provider-owned-pm-edit-hydration
May 10, 2026
Merged

feat(pm-wizard): move edit hydration into provider definitions#1320
aaight merged 1 commit into
devfrom
feature/provider-owned-pm-edit-hydration

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented May 10, 2026

Summary

Card: https://trello.com/c/6a004dc1c8cdf68fbae5dc4b

Moves PM wizard edit-mode hydration out of shared provider-branching state code and into each provider wizard definition. PMWizard now resolves the saved provider through the registered provider wizard before hydrating edit state, so unknown providers fail explicitly instead of returning a partial shared state.

Changes

  • Added ProviderWizardDefinition.buildEditState(initialConfig, configuredKeys) for provider-owned edit hydration.
  • Implemented Trello, JIRA, and Linear hydration in their provider wizard files while preserving existing saved config fields and stored credential detection.
  • Removed the shared provider-branching buildEditState implementation from pm-wizard-state.ts.
  • Updated tests to exercise hydration through provider wizard definitions and registry-backed unknown-provider failure.
  • Updated provider onboarding docs to describe provider-owned edit hydration.

Verification

  • npm test -- --run tests/unit/web/pm-wizard-state.test.ts tests/unit/web/pm-wizard-generic-renderer.test.ts tests/unit/web/pm-provider-registry.test.ts
  • npm run lint:fix
  • npm run lint
  • npm run typecheck
  • npm test
  • npm run test:integration

Note: npm run lint exits 0 and still reports existing warning-level findings outside this change.

🕵️ codex · gpt-5.5 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - provider-owned edit hydration preserves the existing Trello, JIRA, and Linear edit-state behavior, and the registry-backed unknown-provider path is covered. Focused unit tests passed locally: npm test -- --run tests/unit/web/pm-wizard-state.test.ts tests/unit/web/pm-wizard-generic-renderer.test.ts tests/unit/web/pm-provider-registry.test.ts.

🕵️ codex · gpt-5.5 · run details

@aaight aaight merged commit 6f78a56 into dev May 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants