fix(web): move webhook list normalization into providers#1321
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
May 10, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - provider-owned normalization now lives with the Trello/JIRA webhook code, shared wizard state no longer branches on webhook payload shapes, and Linear remains manual-only. Focused web tests pass locally.
🕵️ codex · gpt-5.5 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves active webhook list normalization out of shared wizard state and into the Trello/JIRA provider webhook modules.
Card: https://trello.com/c/6a004df5743908c624ec1d2b
Changes
{ id, callbackURL, active }to{ id, url, active }.{ id, url, enabled }to{ id, url, active }.deriveActiveWebhooksfrompm-wizard-state.tsand deleted its shared-state tests.Verification
npm test -- --run tests/unit/web/trello-webhook-step.test.ts tests/unit/web/jira-webhook-step.test.ts tests/unit/web/linear-webhook-step.test.ts tests/unit/web/pm-wizard-state.test.tsnpm testnpm run typechecknpm run lint(exits successfully; reports unrelated existing warnings)Notes
No webhook creation/deletion tRPC contracts or webhook URL construction changed.
🕵️ codex · gpt-5.5 · run details