Skip to content

fix(web): move webhook list normalization into providers#1321

Merged
aaight merged 1 commit into
devfrom
fix/provider-owned-webhook-normalization
May 10, 2026
Merged

fix(web): move webhook list normalization into providers#1321
aaight merged 1 commit into
devfrom
fix/provider-owned-webhook-normalization

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented May 10, 2026

Summary

Moves active webhook list normalization out of shared wizard state and into the Trello/JIRA provider webhook modules.

Card: https://trello.com/c/6a004df5743908c624ec1d2b

Changes

  • Added Trello-owned normalization from { id, callbackURL, active } to { id, url, active }.
  • Added JIRA-owned normalization from { id, url, enabled } to { id, url, active }.
  • Removed deriveActiveWebhooks from pm-wizard-state.ts and deleted its shared-state tests.
  • Expanded Trello/JIRA webhook step tests for provider normalization and loading states while retaining active list, empty state, create, and delete coverage.
  • Left Linear webhook UI unchanged; its regression test continues to assert no create/delete active-list UI.

Verification

  • npm test -- --run tests/unit/web/trello-webhook-step.test.ts tests/unit/web/jira-webhook-step.test.ts tests/unit/web/linear-webhook-step.test.ts tests/unit/web/pm-wizard-state.test.ts
  • npm test
  • npm run typecheck
  • npm run lint (exits successfully; reports unrelated existing warnings)

Notes

No webhook creation/deletion tRPC contracts or webhook URL construction changed.

🕵️ codex · gpt-5.5 · run details

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - provider-owned normalization now lives with the Trello/JIRA webhook code, shared wizard state no longer branches on webhook payload shapes, and Linear remains manual-only. Focused web tests pass locally.

🕵️ codex · gpt-5.5 · run details

@aaight aaight merged commit a5a47ed into dev May 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants