Skip to content

refactor(pm-wizard): keep PM config builders provider-owned#1323

Merged
aaight merged 1 commit into
devfrom
refactor/provider-owned-pm-config-builders
May 10, 2026
Merged

refactor(pm-wizard): keep PM config builders provider-owned#1323
aaight merged 1 commit into
devfrom
refactor/provider-owned-pm-config-builders

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented May 10, 2026

Summary

Card: https://trello.com/c/6a004dd90c8a7f495e15f8bb

Moves PM integration config serialization fully behind provider wizard definitions so save payloads continue to use manifestDef.buildIntegrationConfig(state) as the single source of truth.

Changes

  • Removed shared Trello, JIRA, and Linear config builder exports from pm-wizard-state.ts.
  • Inlined Linear config serialization into linearProviderWizard.buildIntegrationConfig, matching existing Trello and JIRA provider-owned builders.
  • Updated Trello, JIRA, Linear serialization tests to call provider wizard definitions directly.
  • Updated alert and friction slot round-trip tests to assert through provider wizard definitions.

Verification

  • npx vitest run --project unit-core tests/unit/web/pm-wizard-hooks.test.ts tests/unit/web/wizard-alerts-slot.test.ts tests/unit/web/wizard-friction-slot.test.ts tests/unit/web/pm-wizard-state.test.ts
  • npm run lint:fix
  • npm run lint (passes with existing warnings only)
  • npm run typecheck
  • npm test

🕵️ codex · gpt-5.5 · run details

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the shared PM config builder exports are removed, the Linear serialization now lives on the provider wizard like Trello and JIRA, and the save-path/slot tests assert through provider-owned buildIntegrationConfig without changing the persisted config shape.

🕵️ codex · gpt-5.5 · run details

@aaight aaight merged commit 765240a into dev May 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants