fix(scm): accept body-file for PR reviews#1327
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
May 10, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - The metadata-only change follows the existing file-input pattern, preserves comments parsing, and the focused definition/CLI/prompt tests pass.
🕵️ codex · gpt-5.5 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CreatePRReview CLI/docs mismatch by adding a declarative
--body-filefile input alternative for the required review body.Card: https://trello.com/c/6a008f3d72d70bdc602b1c94
Changes
body-filemetadata tocreatePRReviewDefwithout changing shared CLI or manifest infrastructure.CreatePRReview --body-file.--body-file <path>and--body-file -.Testing
npx vitest run --project unit-core tests/unit/gadgets/github/definitions.test.ts tests/unit/cli/file-input-flags.test.ts tests/unit/backends/shared-nativeToolPrompts.test.tsnpx vitest run --project unit-backends tests/unit/backends/shared-nativeToolPrompts.test.tsnpm run lint:fixnpm run lintnpm run typechecknpm run buildNotes
npm run lintexits 0 but reports seven pre-existing warnings in unrelated files; this PR leaves them untouched.🕵️ codex · gpt-5.5 · run details