Skip to content

fix(scm): accept body-file for PR reviews#1327

Merged
aaight merged 1 commit into
devfrom
fix/create-pr-review-body-file
May 10, 2026
Merged

fix(scm): accept body-file for PR reviews#1327
aaight merged 1 commit into
devfrom
fix/create-pr-review-body-file

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented May 10, 2026

Summary

Fixes the CreatePRReview CLI/docs mismatch by adding a declarative --body-file file input alternative for the required review body.

Card: https://trello.com/c/6a008f3d72d70bdc602b1c94

Changes

  • Added body-file metadata to createPRReviewDef without changing shared CLI or manifest infrastructure.
  • Extended definition, generated native-tool guidance, and real oclif parsing tests for CreatePRReview --body-file.
  • Updated gadget docs and changelog to document --body-file <path> and --body-file -.

Testing

  • npx vitest run --project unit-core tests/unit/gadgets/github/definitions.test.ts tests/unit/cli/file-input-flags.test.ts tests/unit/backends/shared-nativeToolPrompts.test.ts
  • npx vitest run --project unit-backends tests/unit/backends/shared-nativeToolPrompts.test.ts
  • npm run lint:fix
  • npm run lint
  • npm run typecheck
  • npm run build
  • `node bin/cascade-tools.js scm create-pr-review --help | rg -- '--body-file|--comments-file|Read review body'

Notes

npm run lint exits 0 but reports seven pre-existing warnings in unrelated files; this PR leaves them untouched.

🕵️ codex · gpt-5.5 · run details

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - The metadata-only change follows the existing file-input pattern, preserves comments parsing, and the focused definition/CLI/prompt tests pass.

🕵️ codex · gpt-5.5 · run details

@aaight aaight merged commit 1a69ef8 into dev May 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants