Merge dev to main: Sentry REST formatting + inline checklist serialization#1343
Merged
Conversation
…oveChecklistItem addItemToChecklist() anchored insertion at the last checkbox line, so trailing detail/prose lines that belong to that item got displaced under the newly-inserted checkbox. Fix: advance insertIdx past non-empty non-heading lines so the new item always lands after any trailing detail. removeChecklistItem() called removeSectionBlock with targetLineIdx (the checkbox line) even when the section held detail lines after the only checkbox, leaving those lines orphaned before the next heading. Fix: scanSection now tracks lastContentIdx (last non-empty line in section) and the single-item deletion path uses it as the section end. Adds regression tests for both scenarios per reviewer feedback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ions When deleting a checklist item in a multi-item section, also remove any non-checkbox, non-heading, non-blank detail/prose lines that immediately follow the deleted checkbox line. Previously only the checkbox line was spliced out, leaving trailing detail orphaned (e.g. ` Detail for remove` appearing above the next item or attached to the previous one). The single-item section path already used `lastContentIdx` to cover this case; the multi-item `else` branch now scans forward from the target line and removes the whole item block in a single splice. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-checklist-locks fix(pm): serialize inline checklist description updates
* fix(sentry): handle REST issue event formatting * fix(sentry): handle REST request query as tuple pairs, record, or string Widens SentryRequest with a `query` field (tuple pairs | record | string) to cover Sentry's Retrieve-an-Issue-Event REST shape where query params are returned under `data.query` rather than `queryString`. Adds normalizeRequestQuery() helper that falls back from query_string/queryString to the tuple-pairs/record/string shape, and regression tests for each variant plus the precedence rule. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Cascade Bot <bot@cascade.dev> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5 commits since the last dev→main merge:
Test plan
🤖 Generated with Claude Code