feat(progress): post immediate comment on ProgressMonitor.start()#406
Merged
zbigniewsobiecki merged 2 commits intodevfrom Feb 18, 2026
Merged
feat(progress): post immediate comment on ProgressMonitor.start()#406zbigniewsobiecki merged 2 commits intodevfrom
zbigniewsobiecki merged 2 commits intodevfrom
Conversation
chore: release - merge dev into main
Collaborator
|
🔍 Reviewing PR... |
nhopeatall
approved these changes
Feb 18, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean implementation of immediate progress comments. The race condition between postInitialComment() and the first tick() is correctly handled by awaiting the stored promise. Error paths degrade gracefully: if the initial comment fails, progressCommentId stays null and the existing fallback in postProgress() creates a new comment on the first tick. Tests cover all the important scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProgressMonitor.start()is called, eliminating the 5-minute wait for the first timer ticktick()so the first tick updates the same comment instead of creating a duplicateformatInitialMessage()) for instant response; saves LLM calls for real progress updatesstart(), ticks update viaupdateComment)Card: https://trello.com/c/ABKnb87g/37-when-implementing-we-should-create-a-new-comment-on-the-card-issue-immediately-that-we-will-continuously-update-as-we-go-right-n
Test plan
posts initial comment immediately on start()— verifiesaddCommentcalled at start with correct messagefirst tick updates initial comment (not creates new)— verifies race condition resolved correctlyhandles failure of initial comment gracefully— verifies WARN log, no crashno crash when PM provider is null on start()— verifies null-safe pathstart(), ticksupdateComment)🤖 Generated with Claude Code