fix(router): prevent webhook loop from JIRA reaction fallback#426
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 19, 2026
Merged
fix(router): prevent webhook loop from JIRA reaction fallback#426zbigniewsobiecki merged 1 commit intodevfrom
zbigniewsobiecki merged 1 commit intodevfrom
Conversation
The JIRA acknowledge reaction had a fallback path that posted a 💭 comment when the reactions API returned 404. This comment triggered a new `comment_created` webhook, which queued another job, which posted another fallback comment — creating an infinite loop. Changes: - Remove the JIRA fallback comment entirely from sendJiraReaction() - Scope acknowledge reactions to comment events only across all platforms (Trello commentCard, GitHub issue_comment/PR review comment, JIRA comment_created/comment_updated) instead of firing on every processable event - Update tests to verify no fallback comment is posted Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendJiraReaction()— when the reactions API returned 404, it posted a 💭 comment which triggered a newcomment_createdwebhook, creating an infinite loop that spawned containers endlesslycommentCard, GitHubissue_comment/pull_request_review_comment, JIRAcomment_created/comment_updated) instead of firing on every processable eventRoot cause
Test plan
reactions.test.tsupdated: 20/20 pass🤖 Generated with Claude Code