test(cli): add unit tests for dashboard runs CLI commands#939
Merged
Conversation
nhopeatall
approved these changes
Mar 17, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Well-structured unit tests that follow the established DashboardCommand test pattern from integration-credentials.test.ts. All 9 runs CLI commands are covered with correct tRPC client mocking, flag/argument mapping verified against the source implementations, and the vi.useFakeTimers() approach for the debug polling tests is sound. CI is green.
🕵️ claude-code · claude-opus-4-6 · run details
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/cli/dashboard/runs/runs.test.tswith 34 unit tests covering all 9 runs CLI commands (list,show,logs,llm-calls,llm-call,debug,trigger,retry,cancel)DashboardCommandpattern fromtests/unit/cli/dashboard/projects/integration-credentials.test.ts— mocksloadConfig,createDashboardClient, andchalk; uses amakeClient()factoryvi.useFakeTimers()for thedebug --analyze --waitpolling testsTest coverage per command
getById.query, JSON outputcompleted, stops onidle, logs timeout after 5-min deadline withvi.useFakeTimers()Test plan
npx vitest run --project unit-core tests/unit/cli/dashboard/runs/— 34 tests passnpx biome check tests/unit/cli/dashboard/runs/runs.test.ts— no lint errorsTrello card: https://trello.com/c/7qP5NXnK/458-as-a-developer-i-want-unit-tests-for-dashboard-runs-cli-commands-so-that-run-management-flows-are-covered
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details