Skip to content

Fix #1229: Drop support for Scala 2.11#1230

Merged
alexandru merged 18 commits intomonix:series/4.xfrom
alexandru:drop-2.11
Aug 12, 2020
Merged

Fix #1229: Drop support for Scala 2.11#1230
alexandru merged 18 commits intomonix:series/4.xfrom
alexandru:drop-2.11

Conversation

@alexandru
Copy link
Copy Markdown
Member

@alexandru alexandru commented Aug 11, 2020

See #1229 for details.

Changes:

  • removed 2.11 from CI (build.yml)
  • removed 2.11 specific source directories from build.sbt
  • refactored the code:
    • changed anonymous Runnable instances to SAMs (wherever I spotted instances that could be changed)
    • removed source-specific compatibility hacks meant for 2.11
    • got rid of scala_2.12+ directories, since that code essentially becomes valid for all supported Scala versions
  • updated the README

@alexandru alexandru changed the title Fix #1229: Drop support for Scala 2.11 WIP — Fix #1229: Drop support for Scala 2.11 Aug 11, 2020
@alexandru alexandru changed the title WIP — Fix #1229: Drop support for Scala 2.11 Fix #1229: Drop support for Scala 2.11 Aug 11, 2020
@alexandru alexandru requested a review from Avasil August 11, 2020 15:06
@alexandru alexandru changed the base branch from master to series/3.x August 11, 2020 18:11
@alexandru alexandru changed the base branch from series/3.x to series/4.x August 11, 2020 18:53
@alexandru
Copy link
Copy Markdown
Member Author

Note that I've switched the base to series/4.x.

@alexandru alexandru merged commit 4e92eaf into monix:series/4.x Aug 12, 2020
@alexandru alexandru deleted the drop-2.11 branch August 12, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants