feat: Enhance CMake and build scripts with improved configuration #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the build configuration and scripts for the project. The most important changes include setting the default build type to Debug, adding parallel job support for builds, and improving error handling in scripts.
Build configuration improvements:
CMakeLists.txt: Set the default build type to Debug and added basic compiler flags for GNU and Clang compilers. Also, organized and clarified comments for different sections.Script enhancements:
scripts/build_debug.sh: Added support for specifying the number of parallel jobs with the-jor--jobsoption, and improved error handling by checking the build result and exiting if the build fails. [1] [2] [3] [4]scripts/run_tests.sh: Modified the script to use parallel jobs for building and improved error handling by removing the-xoption fromsetand adding a comment for creating the build directory. [1] [2]… parallel build support