Fixes for scene files and AlignOf optimization#596
Merged
Conversation
monkeyman192
force-pushed
the
recent_fixes
branch
from
e2f7ad1 to
09701cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First set of changes to try fix some issues.
This should get scene files working again.
I had to remove the custom deserialization code since it was causing issues now that the
NameHashfield is before theNamefield. I don't think this was really being used anyway so hopefully it's fine... (The value it would set was wrong anyway...)I also added an optimization to the
AlignOfmethod inNMSTemplateto utilize the fact that the first field of a class will always have the largest offset, so we no longer need to recursively go through all fields of a class to figure out the alignment, but can instead stop at the first one. Not sure if this will have any noticable change, but it's a free optimization...