Skip to content

refactor: rework highlight mode, colorful, flipped and blind to pure css#5568

Merged
Miodec merged 16 commits intomasterfrom
test-ui-refactor
Jul 9, 2024
Merged

refactor: rework highlight mode, colorful, flipped and blind to pure css#5568
Miodec merged 16 commits intomasterfrom
test-ui-refactor

Conversation

@Miodec
Copy link
Copy Markdown
Member

@Miodec Miodec commented Jul 5, 2024

Also adds a .typed class to all words that were already typed to allow for easier advanced theming.

Closes #5561

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jul 5, 2024
@fehmer
Copy link
Copy Markdown
Member

fehmer commented Jul 6, 2024

  • themes rgb, grape, aurora, fire, trance in mode flipped does not use the animation
  • not sure if theme rainbow trail should use the animation without fading to while in flipped mode

@fehmer
Copy link
Copy Markdown
Member

fehmer commented Jul 8, 2024

I'm not sure if this is on purpose. The "special" themes like rainbow trail de-highlight the typed letters even if you are in e.g. `highlight next word" mode. "Regular" themes highlight the complete word while you type it.

Theme 9009
image
Theme rainbow trail
image

@fehmer fehmer self-requested a review July 9, 2024 07:00
@fehmer
Copy link
Copy Markdown
Member

fehmer commented Jul 9, 2024

  • rainbow trail in flipped mode + word highlight does not use fadeout for typed words
  • grape, fire, trance and aurora theme non-flipped + word highlight de-highlights typed letter

fehmer
fehmer previously approved these changes Jul 9, 2024
@Miodec Miodec merged commit 9f924f3 into master Jul 9, 2024
@Miodec Miodec deleted the test-ui-refactor branch July 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight not working in rainbow trail theme

3 participants