impr: reduce initial loading time of settings page (@fehmer)#5583
Merged
impr: reduce initial loading time of settings page (@fehmer)#5583
Conversation
monkeytypegeorge
added
frontend
fehmer
force-pushed
the
feature/font-previews
branch
from
a2a1a3f to
4deb81c
Compare
fehmer
force-pushed
the
feature/font-previews
branch
from
4deb81c to
d137ca8
Compare
Miodec
reviewed
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings page is loading all available fonts to display the button with a font preview. This increases the initial page load as we add more and more available fonts. With the improvements of #5582 we are still loading 2041kb of fonts.
By generating preview fonts we can reduce the size down to 84kb. When the user selects a font it still has to be loaded fully.