Skip to content

feat(languages): add League of Legends language (@hailfire805)#5590

Merged
Miodec merged 5 commits intomonkeytypegame:masterfrom
Hailfire805:master
Jul 9, 2024
Merged

feat(languages): add League of Legends language (@hailfire805)#5590
Miodec merged 5 commits intomonkeytypegame:masterfrom
Hailfire805:master

Conversation

@Hailfire805
Copy link
Copy Markdown
Contributor

Description

Adding collection of significant proper nouns from the MOBA League of Legends

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jul 8, 2024
Copy link
Copy Markdown
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 7ed6662 into monkeytypegame:master Jul 9, 2024
@Jabster28
Copy link
Copy Markdown

Jabster28 commented Jul 9, 2024

Is the rightToLeft supposed to be true in groups.json? All of the names are reversed and right-aligned:
Screenshot_20240709-231736.png

@Hailfire805

@Jabster28
Copy link
Copy Markdown

Ah whoops, there's already a PR: #5597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants