Skip to content

ci: optimize prime-cache checkout (@fehmer)#5657

Merged
Miodec merged 2 commits intomasterfrom
feature/ci-optimize-prime-cache
Jul 26, 2024
Merged

ci: optimize prime-cache checkout (@fehmer)#5657
Miodec merged 2 commits intomasterfrom
feature/ci-optimize-prime-cache

Conversation

@fehmer
Copy link
Copy Markdown
Member

@fehmer fehmer commented Jul 26, 2024

Only checkout the package-lock.json initially because it is used to fetch the cache.
If the cache is missing checkout all files and run the install to fill the cache.

Reduces the time of prime-cache in case the cache is up to date from ~10 seconds down to one second.

@monkeytypegeorge monkeytypegeorge added backend Server stuff and removed backend Server stuff labels Jul 26, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions
Copy link
Copy Markdown
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@fehmer fehmer force-pushed the feature/ci-optimize-prime-cache branch from 843606d to 44facd8 Compare July 26, 2024 08:37
@monkeytypegeorge monkeytypegeorge added backend Server stuff and removed backend Server stuff labels Jul 26, 2024
@fehmer fehmer force-pushed the feature/ci-optimize-prime-cache branch from a726754 to cc44633 Compare July 26, 2024 08:45
@fehmer fehmer force-pushed the feature/ci-optimize-prime-cache branch from cc44633 to 5edb603 Compare July 26, 2024 08:46
@monkeytypegeorge monkeytypegeorge removed the backend Server stuff label Jul 26, 2024
Comment thread .github/workflows/monkey-ci.yml Outdated
if: needs.pre-ci.outputs.should-build-be == 'true' || needs.pre-ci.outputs.should-build-fe == 'true' || needs.pre-ci.outputs.should-build-pkg == 'true' || needs.pre-ci.outputs.assets-json == 'true'
steps:
- uses: actions/checkout@v4
- name: checkout package-lock
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital C please ;D

@Miodec Miodec merged commit ed4b072 into master Jul 26, 2024
@Miodec Miodec deleted the feature/ci-optimize-prime-cache branch July 26, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants