Skip to content

Conversation

@Miodec
Copy link
Member

@Miodec Miodec commented Dec 19, 2025

vite plugin checker seems to happily spawn a new linting process per file save, causing issues. This vibe coded solution kills the previously running process. It also splits linting into two steps to get some fast fail behavior.

I (AI) tried to merge it into one file but the overlay refused to show that way.

@Miodec Miodec requested review from Copilot and fehmer and removed request for fehmer December 19, 2025 13:19
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Dec 19, 2025
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Dec 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces vite-plugin-checker with a custom oxlint checker implementation to address issues with multiple concurrent linting processes being spawned on each file save. The custom solution includes process management that kills previous runs before starting new ones and implements a two-step linting approach (fast non-type-aware check followed by type-aware check) for faster failure feedback.

Key Changes:

  • Removed vite-plugin-checker dependency and implemented custom oxlintChecker Vite plugin
  • Added two-phase linting: fast baseline check followed by type-aware check for improved performance
  • Implemented process management to kill previous linting processes when new changes are detected

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
pnpm-lock.yaml Removed vite-plugin-checker and its transitive dependencies from the lock file
frontend/package.json Removed vite-plugin-checker from devDependencies
frontend/vite.config.ts Updated plugin import and configuration to use custom oxlintChecker instead of vite-plugin-checker
frontend/vite-plugins/oxlint-checker.ts New custom Vite plugin implementing debounced linting with process management, two-phase checks (fast + type-aware), and HMR integration
frontend/vite-plugins/oxlint-overlay.ts New browser overlay component showing real-time linting status with visual feedback for errors, warnings, and running state
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 11 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 13 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Miodec Miodec merged commit eb92e1a into master Dec 19, 2025
13 checks passed
@Miodec Miodec deleted the vibe-checker branch December 19, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants