fix: add error logging to empty catch block in keymap.ts (@Dawn-Fighter)#7344
Closed
Dawn-Fighter wants to merge 2 commits intomonkeytypegame:masterfrom
Closed
fix: add error logging to empty catch block in keymap.ts (@Dawn-Fighter)#7344Dawn-Fighter wants to merge 2 commits intomonkeytypegame:masterfrom
Dawn-Fighter wants to merge 2 commits intomonkeytypegame:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling in the keymap.ts file by adding proper error logging to a previously empty catch block in the flashKey function. This ensures that animation errors are logged instead of being silently swallowed, improving debuggability.
Changes:
- Added error logging with an appropriate error message to the catch block in the
flashKeyfunction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Not sure why is this needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an empty catch block in the
flashKeyfunction that was silently swallowing animation errors.Changes
frontend/src/ts/elements/keymap.tsconsole.logfor consistency with the codebase's internal logging styleType of Change
Code Change
Before:
After:
Testing
instanceof Error) before accessing error propertiesAdditional Context
This change improves debugging by logging animation errors instead of silently ignoring them, making it easier to diagnose issues with keymap flash animations.