chore: add signal for authentication state / user id (@fehmer)#7539
Merged
chore: add signal for authentication state / user id (@fehmer)#7539
Conversation
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a SolidJS signal-based authentication state management to track the user ID and login status. The signal is updated via Firebase's onAuthStateChanged callback.
Changes:
- Add
userIdsignal withgetUserId/isLoggedInderived state - Integrate
setUserIdcalls in Firebase auth initialization and error paths
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/ts/signals/core.ts | Adds userId signal and derived getUserId/isLoggedIn memos |
| frontend/src/ts/firebase.ts | Updates userId signal in auth state changes and initialization errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.