fix(command-line): hide Ctrl/Cmd + Shift + P hint on Firefox (@d1rshan)#7690
Closed
d1rshan wants to merge 4 commits intomonkeytypegame:masterfrom
Closed
fix(command-line): hide Ctrl/Cmd + Shift + P hint on Firefox (@d1rshan)#7690d1rshan wants to merge 4 commits intomonkeytypegame:masterfrom
d1rshan wants to merge 4 commits intomonkeytypegame:masterfrom
Conversation
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts frontend UI shortcut hints to avoid advertising Ctrl/Cmd + Shift + P on Firefox, where that shortcut is reserved by the browser and can’t be used reliably for opening Monkeytype’s command line.
Changes:
- Hide
Ctrl/Cmd + Shift + Pin shortcut hint text when running on Firefox. - Continue showing the
Esc/Tab(depending on quick restart setting) hint in Settings, Footer keytips, and About page.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/src/ts/pages/settings.ts | Updates Settings tip HTML to omit the Ctrl/Cmd + Shift + P hint on Firefox. |
| frontend/src/ts/components/pages/AboutPage.tsx | Updates About page “keybinds” copy to conditionally omit the Ctrl/Cmd + Shift + P hint on Firefox. |
| frontend/src/ts/components/layout/footer/Keytips.tsx | Updates footer keytips to conditionally omit the Ctrl/Cmd + Shift + P hint on Firefox. |
Miodec
requested changes
Mar 21, 2026
Member
Miodec
left a comment
Miodec
left a comment
There was a problem hiding this comment.
Please address copilot comments.
Miodec
added
waiting for update
d1rshan
force-pushed
the
fix/firefox-command-line-keybind
branch
from
39d517c to
d897d43
Compare
github-actions
bot
removed
the
waiting for update
github-actions
bot
added
the
waiting for review
Member
|
Hey sorry, i completely forgot that #7691 will pretty much completely replace your changes. Well include your name in the pr title to still credit you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hide the Cmd/Ctrl + Shift + P shortcut on Firefox, where it is reserved for private windows and not usable by the app.
Changes
Notes
UI-only change. No changes to keybind logic.
Testing
Closes #7689