impr(input-validation): clean preset name input when adding (@byseif21)#7703
Merged
Miodec merged 1 commit intomonkeytypegame:masterfrom Mar 22, 2026
Merged
Conversation
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ValidatedHtmlInputElement.setValue(null) to clear the underlying input value (not just reset validation UI/state), preventing stale text from persisting when switching from “edit preset” to “add preset”.
Changes:
- Clear the input’s value when
setValue(null)is called. - Keep existing behavior of hiding the indicator and resetting validation status without triggering validation.
byseif21
changed the title
byseif21
changed the title
byseif21
changed the title
Miodec
approved these changes
Mar 22, 2026
github-actions
bot
removed
the
waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValidatedHtmlInputElementwould reset its validation status but keep the old text in the input field1- go to presets
2- click edit from one of the existing ones
3- go back and click add preset
4- notice the edit one's name is there