fix(screenshot): remove spacer causing layout jump (@byseif21)#7750
Merged
Miodec merged 1 commit intomonkeytypegame:masterfrom Mar 30, 2026
Merged
fix(screenshot): remove spacer causing layout jump (@byseif21)#7750Miodec merged 1 commit intomonkeytypegame:masterfrom
Miodec merged 1 commit intomonkeytypegame:masterfrom
Conversation
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the screenshotSpacer DOM insertion/removal in the screenshot-test helper to prevent layout shifts (“layout jump”) during screenshot generation in the frontend test tooling.
Changes:
- Stop removing
.pageTest .screenshotSpacerduringrevert(). - Stop forcibly removing/adding a
.screenshotSpaceringenerateCanvas()before rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after the solid migration, obsolete & no longer being manually removed from the DOM layout during screenshot capture