Skip to content

impr: clean up form field fallback placeholder behavior (@byseif21) #7781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miodec merged 4 commits into from
Apr 7, 2026
Merged

impr: clean up form field fallback placeholder behavior (@byseif21) #7781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3337260
impr: clean up form field placeholder behavior
byseif21 Apr 6, 2026
ee3d68f
add placeholder to custom textarea
byseif21 Apr 6, 2026
9aa6625
Merge branch 'master' into impr/clean-up-form-field-placeholder-behavior
byseif21 Apr 6, 2026
13513b5
.
byseif21 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/ts/components/modals/CustomTextModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,7 @@ export function CustomTextModal(): JSXElement {
<TextareaField
field={field}
ref={textareaRef}
placeholder="type or paste your custom text"
class="min-h-182.5 self-start overflow-x-hidden overflow-y-scroll p-4 text-base font-(--font) text-text"
onKeyDown={handleTextareaKeydown}
onKeyPress={handleTextareaKeypress}
Expand Down
16 changes: 4 additions & 12 deletions frontend/src/ts/components/modals/WordFilterModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,24 +249,20 @@ export function WordFilterModal(props: {
<div class="grid gap-1">
<div class="text-sub">min length</div>
<form.Field name="minLength">
{(field) => (
<InputField field={field} type="number" placeholder="" />
)}
{(field) => <InputField field={field} type="number" />}
</form.Field>
</div>
<div class="grid gap-1">
<div class="text-sub">max length</div>
<form.Field name="maxLength">
{(field) => (
<InputField field={field} type="number" placeholder="" />
)}
{(field) => <InputField field={field} type="number" />}
</form.Field>
</div>
</div>
<div class="grid gap-1">
<div class="text-sub">include</div>
<form.Field name="include">
{(field) => <InputField field={field} placeholder="" />}
{(field) => <InputField field={field} />}
</form.Field>
<form.Field
name="exactMatch"
Expand All @@ -292,11 +288,7 @@ export function WordFilterModal(props: {
<div class="text-sub">exclude</div>
<form.Field name="exclude">
{(field) => (
<InputField
field={field}
disabled={isExactMatch()}
placeholder=""
/>
<InputField field={field} disabled={isExactMatch()} />
)}
</form.Field>
</div>
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/ts/components/pages/login/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ export function Login(): JSXElement {
children={(field) => (
<InputField
field={field}
placeholder="email"
autocomplete="current-email"
disabled={!getLoginPageInputsEnabled()}
/>
Expand All @@ -116,6 +117,7 @@ export function Login(): JSXElement {
children={(field) => (
<InputField
field={field}
placeholder="password"
type="password"
autocomplete="current-password"
disabled={!getLoginPageInputsEnabled()}
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/ts/components/pages/login/Register.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export function Register(): JSXElement {
children={(field) => (
<InputField
field={field}
placeholder="username"
showIndicator
autocomplete="new-username"
disabled={!getLoginPageInputsEnabled()}
Expand All @@ -185,6 +186,7 @@ export function Register(): JSXElement {
children={(field) => (
<InputField
field={field}
placeholder="email"
showIndicator
autocomplete="new-email"
disabled={!getLoginPageInputsEnabled()}
Expand Down Expand Up @@ -235,6 +237,7 @@ export function Register(): JSXElement {
children={(field) => (
<InputField
field={field}
placeholder="password"
showIndicator
autocomplete="new-password"
type="password"
Expand Down
1 change: 1 addition & 0 deletions frontend/src/ts/components/pages/profile/ProfileSearchPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export function ProfileSearchPage(): JSXElement {
children={(field) => (
<InputField
field={field}
placeholder="username"
showIndicator
autocomplete="new-username"
disabled={!isEditable()}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/ts/components/ui/form/InputField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function InputField(props: {
props.class,
)}
type={props.type ?? "text"}
placeholder={props.placeholder ?? (props.field().name as string)}
placeholder={props.placeholder ?? ""}
// oxlint-disable-next-line react/no-unknown-property
autocomplete={props.autocomplete}
name={props.field().name as string}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/ts/components/ui/form/TextareaField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function TextareaField(props: {
)}
id={props.field().name as string}
name={props.field().name as string}
placeholder={props.placeholder ?? (props.field().name as string)}
placeholder={props.placeholder ?? ""}
value={props.field().state.value as string}
onBlur={() => props.field().handleBlur()}
onInput={(e) => props.field().handleChange(e.currentTarget.value)}
Expand Down
Loading