Conversation
Miodec
changed the title
github-actions
Bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the custom Conditional / AnimeConditional helper components and migrates call sites to SolidJS control-flow primitives (<Show>) plus explicit anime presence/animation wrappers.
Changes:
- Deleted
ConditionalandAnimeConditionalcomponents (and their Storybook stories + tests). - Replaced usages of
Conditionalwith<Show when ... fallback ...>across UI components. - Replaced
AnimeConditionalusage with<AnimePresence>+<Show>+<Anime>composition where needed.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/storybook/stories/Conditional.stories.tsx | Removes Storybook coverage for deleted Conditional component. |
| frontend/storybook/stories/AnimeConditional.stories.tsx | Removes Storybook coverage for deleted AnimeConditional component. |
| frontend/src/ts/components/ui/table/DataTable.tsx | Replaces sortable-header conditional rendering with <Show> + fallback. |
| frontend/src/ts/components/popups/alerts/NotificationHistory.tsx | Replaces message rendering conditional with <Show> + fallback. |
| frontend/src/ts/components/pages/profile/UserDetails.tsx | Replaces account-page action button branch selection with <Show> + fallback. |
| frontend/src/ts/components/pages/login/LoginPage.tsx | Replaces signup-disabled branching with <Show> + fallback. |
| frontend/src/ts/components/pages/leaderboard/UserRank.tsx | Replaces null-data branching with <Show> + fallback. |
| frontend/src/ts/components/pages/leaderboard/Table.tsx | Replaces type-based table selection with <Show> + fallback. |
| frontend/src/ts/components/layout/overlays/Notifications.tsx | Replaces innerHTML conditional rendering with <Show> + fallback. |
| frontend/src/ts/components/layout/overlays/Banners.tsx | Replaces multiple Conditional blocks with <Show> + fallback. |
| frontend/src/ts/components/layout/header/Nav.tsx | Replaces AnimeConditional with explicit <AnimePresence> + <Show> + <Anime>. |
| frontend/src/ts/components/common/anime/index.ts | Removes AnimeConditional export from the anime barrel. |
| frontend/src/ts/components/common/anime/AnimeConditional.tsx | Deletes the AnimeConditional component implementation. |
| frontend/src/ts/components/common/User.tsx | Replaces AnimeConditional / Conditional with <AnimePresence> + <Show> and <Show> respectively. |
| frontend/src/ts/components/common/Separator.tsx | Replaces Conditional with <Show> + fallback. |
| frontend/src/ts/components/common/LoadingCircle.tsx | Replaces Conditional with <Show> + fallback. |
| frontend/src/ts/components/common/DiscordAvatar.tsx | Replaces Conditional with <Show> + fallback. |
| frontend/src/ts/components/common/Conditional.tsx | Deletes the Conditional component implementation. |
| frontend/src/ts/components/common/Button.tsx | Replaces anchor/button branching with <Show> + fallback. |
| frontend/src/ts/components/common/AsyncContent.tsx | Replaces alwaysShowContent conditional with nested <Show> logic. |
| frontend/tests/components/common/anime/AnimeConditional.spec.tsx | Removes tests for deleted AnimeConditional. |
| frontend/tests/components/common/Conditional.spec.tsx | Removes tests for deleted Conditional. |
fehmer
previously approved these changes
May 2, 2026
github-actions
Bot
removed
the
waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.