Skip to content

fix(signup): signup with provider not working (@fehmer) #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miodec merged 2 commits into from
Jun 2, 2026
+4 −3
Merged

fix(signup): signup with provider not working (@fehmer) #8046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e620f93
fix(signup): signup with provider not working (@fehmer)
fehmer Jun 2, 2026
192f379
Merge branch 'master' into feature/google-signup
fehmer Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/ts/firebase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export async function signInWithEmailAndPassword(
return result;
}

function setUserState(
export function setUserState(
options: {
uid: string;
emailVerified: boolean;
Expand Down Expand Up @@ -166,10 +166,10 @@ export async function signInWithPopup(
throw translateFirebaseError(error, "Failed to sign in with popup");
}
const additionalUserInfo = getAdditionalUserInfo(signedInUser);
setUserState(signedInUser.user);
if (additionalUserInfo?.isNewUser) {
googleSignUpEvent.dispatch({ signedInUser, isNewUser: true });
} else {
setUserState(signedInUser.user);
ignoreAuthCallback = false;
await readyCallback?.(true, signedInUser.user);
}
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/ts/modals/google-sign-up.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import * as CaptchaController from "../controllers/captcha-controller";
import { showLoaderBar, hideLoaderBar } from "../states/loader-bar";
import { googleSignUpEvent } from "../events/google-sign-up";
import AnimatedModal from "../utils/animated-modal";
import { resetIgnoreAuthCallback } from "../firebase";
import { resetIgnoreAuthCallback, setUserState } from "../firebase";
import { ValidatedHtmlInputElement } from "../elements/input-validation";
import { UserNameSchema } from "@monkeytype/schemas/users";
import { remoteValidation } from "../utils/remote-validation";
Expand Down Expand Up @@ -105,6 +105,7 @@ async function apply(): Promise<void> {
}

if (response.status === 200) {
setUserState(signedInUser.user);
await updateProfile(signedInUser.user, { displayName: name });
await sendEmailVerification(signedInUser.user);
showSuccessNotification("Account created");
Expand Down
Loading