MN-430: PhotoHUDPreview with SightsSlider + Counter #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dlymonk merged 33 commits into refacto/main from refacto/MN-430

Jan 5, 2024

Contributor

dlymonk commented Dec 13, 2023

No description provided.

souyahia-monk reviewed

View reviewed changes

packages/public/common/src/hooks/useObjectTranslation.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/common/src/hooks/useObjectTranslation.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/common/src/hooks/useObjectTranslation.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDPreview.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDPreview.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDPreview.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDPreview.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDPreview.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDPreview.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDPreview.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...tion-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDSightsCounter.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...tion-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDSightsCounter.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...ction-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDSightsSlider.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...ction-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDSightsSlider.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...ction-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDPreview/PhotoCaptureHUDSightsSlider.tsx Outdated Show resolved Hide resolved

David LY and others added 11 commits

December 15, 2023 11:12


          Added ObjectTranlation type

f467b28


          Added useObjectTranslation hook

032288f


          Renamed CaptureCaptureHUDButtons to PhotoCaptureHUDButtons

e8a6560


          Added PhotoCaptureHUDSightsSlider component: display a scrolling sigh…

bdda7a4

…ts label


          Added PhotoCaptureHUDCounter component

11a3602


          Added PhotoCaptureHUDPreview component that render SightsSlider and C…

8fc01cf

…ounter


          Added PhotoCaptureHUD that render the HUDPreview and HUDButtons

83ae2cb


          Fix: lint

9cc3b44


          fix: applying feedback review, Sights liftup in PhotoCaptureHUD

b763122


          rename Slider to SightsSlider

730e020


          useObjectTranslation/CaptureHUDPreviewtests added + fix

9aea4d7

dlymonk force-pushed the refacto/MN-430 branch from b7ba358 to d3eb91e Compare

December 20, 2023 14:17


          directory structure changed by PreviewSight and PreviewAddDamage view

412cee7

directory structure changed to be more clear with PreviewSight and PreviewAddDamage view

dlymonk force-pushed the refacto/MN-430 branch from e42111e to 412cee7 Compare

December 20, 2023 14:40


          TSDoc added to i18n language types

5b81177

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/PhotoCapture.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUD.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...rc/PhotoCaptureHUD/PhotoCaptureHUDAddDamagePreview/PhotoCaptureHUDAddDamagePreview.styles.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...eb/src/PhotoCaptureHUD/PhotoCaptureHUDSightPreview/AddDamageButton/AddDamageButton.styles.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...re-web/src/PhotoCaptureHUD/PhotoCaptureHUDSightPreview/SightsCounter/SightsCounter.styles.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...on-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDSightPreview/SightsSlider/SightsSlider.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...on-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDSightPreview/SightsSlider/SightsSlider.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDSightPreview/hook.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/PhotoCaptureHUD/hook.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/PhotoCaptureHUD/hook.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/PhotoCaptureHUD/PhotoCaptureHUDSightPreview/hook.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/PhotoCaptureHUD/translations/de.json Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/hooks/useCameraConfig.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/hooks/useHUDMode.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/hooks/useSightState.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/hooks/useSightState.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/src/hooks/useSightState.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/test/PhotoCapture.test.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

...ection-capture-web/test/PhotoCaptureHUD/PhotoCaptureHUDSightPreview/AddDamageButton.test.tsx Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/test/hooks/useHUDMode.test.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/test/hooks/useSightState.test.tsx Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/public/inspection-capture-web/test/hooks/useSightState.test.tsx Show resolved Hide resolved


          fixing PR (check comments)

b59f3ca

dlymonk force-pushed the refacto/MN-430 branch from 2061d6f to b59f3ca Compare

January 4, 2024 08:59


          fixing PR (check comments)

d016fed

dlymonk force-pushed the refacto/MN-430 branch from 159f2cd to d016fed Compare

January 4, 2024 17:09

souyahia-monk and others added 2 commits

January 5, 2024 11:20


          Created SwitchButton component (#656)

fd1fd92


          import changeAlpha function in usePhotoHUDButtonBackground hook

aaedcb5

dlymonk merged commit 97914b2 into refacto/main

dlymonk deleted the refacto/MN-430 branch

January 5, 2024 13:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet