Created SwitchButton component #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlymonk
approved these changes
Jan 2, 2024
dlymonk
pushed a commit
that referenced
this pull request
Jan 5, 2024
dlymonk
added a commit
that referenced
this pull request
Jan 5, 2024
* Added ObjectTranlation type * Added useObjectTranslation hook * Renamed CaptureCaptureHUDButtons to PhotoCaptureHUDButtons * Added PhotoCaptureHUDSightsSlider component: display a scrolling sights label * Added PhotoCaptureHUDCounter component * Added PhotoCaptureHUDPreview component that render SightsSlider and Counter * Added PhotoCaptureHUD that render the HUDPreview and HUDButtons * Fix: lint * fix: applying feedback review, Sights liftup in PhotoCaptureHUD * rename Slider to SightsSlider * useObjectTranslation/CaptureHUDPreviewtests added + fix * directory structure changed by PreviewSight and PreviewAddDamage view directory structure changed to be more clear with PreviewSight and PreviewAddDamage view * TSDoc added to i18n language types * fix on tests and import * useSightLabel's hook moved to @monkvision/common + SightSlider component styles sight.id: string instead of sight:Sight * SightsSlider tests done * sight overlay now take all preview screen space * sight centered in slider when selected * responsive style added when portrait view * when the picture is taken, the sight button(in the slider) changed to a light color and have a check icon * TSDoc useSightLabel * keep sight button selected in the center when switching back to main preview * TSDoc useObjectTranslation & useSightLabel hooks * fixing PR review comments * PhotoCapture logic and component plug to camera. refacto + rename funct/var * renaming component for more readability + callback mode (avoiding rerender camera) + button in AddDamagePreview traduction in sync * tests + i18nAddDamage instance moved to separate file * SightOverlay stays in CameraPreview frame in both landscape and portrait mode. * SightOverlay equals CameraPreview in aspect ratio * fixing PR (check comments) * fixing PR (check comments) * Created SwitchButton component (#656) * import changeAlpha function in usePhotoHUDButtonBackground hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.