MN-427 : Created PhotoCaptureHUDAddDamagePreview component #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlymonk
requested review from
deepakglobant,
rohitsharma120582 and
souyahia-monk
dlymonk
force-pushed
the
refacto/MN-427
branch
2 times, most recently
from
2f95a90 to
bac8ff5
Compare
dlymonk
force-pushed
the
refacto/MN-427
branch
from
bac8ff5 to
23ed41e
Compare
dlymonk
commented
Jan 15, 2024
|
|
||
| const { t } = useTranslation(); | ||
| const { bgColor } = usePhotoHUDButtonBackground(); | ||
| const addDamagePreviewMode = AddDamagePreviewMode.DEFAULT; |
Contributor
Author
There was a problem hiding this comment.
It's for this component: <DamageCounter addDamagePreviewMode={addDamagePreviewMode} />
I wanted to make it more lisible, but actually it's useless
Instead, I can pass it directly as a props: addDamagePreviewMode={AddDamagePreviewMode.DEFAULT}
souyahia-vizion
approved these changes
Jan 16, 2024
souyahia-monk
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.