Skip to content

Conversation

@dlymonk
Copy link
Contributor

@dlymonk dlymonk commented Feb 20, 2024

No description provided.

@souyahia
Copy link

Also now that I think about it : when I wrote the code for the Camera in the refacto, I thought it was a good idea to let the user select the device manually using a deviceId in the constraints given to the Camera component. But after Deepak's work on the camera, it appears that this is a mistake : we should always handle the device selection ourselves to prevent users from using zoomed cameras by inadvertance.

So could you take the time to remove this option in the code please? Remove every option to select the deviceId in the camera constraints (everywhere in the code : in the Camera props, in the getMediaConstraints, in the type definitions, in the doc etc.)

@dlymonk dlymonk force-pushed the refacto/POC-portrait-camera branch 3 times, most recently from 9b81b18 to a9419cd Compare February 23, 2024 10:51
@dlymonk dlymonk force-pushed the refacto/POC-portrait-camera branch from a9419cd to e196f08 Compare February 23, 2024 10:57
@dlymonk dlymonk merged commit f4f2d9b into refacto/main Feb 23, 2024
@dlymonk dlymonk deleted the refacto/POC-portrait-camera branch February 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants