Fix VB default value for class parameters bug#499
Merged
joelmartinez merged 2 commits intomono:developfrom May 27, 2020
hiihellox10:xiao/fix-VB-default-value-for-class-parameters
Merged
Fix VB default value for class parameters bug#499joelmartinez merged 2 commits intomono:developfrom hiihellox10:xiao/fix-VB-default-value-for-class-parameters
joelmartinez merged 2 commits intomono:developfrom
hiihellox10:xiao/fix-VB-default-value-for-class-parameters
Conversation
|
|
joelmartinez
requested changes
May 26, 2020
Member
joelmartinez
left a comment
joelmartinez
left a comment
There was a problem hiding this comment.
Very small change requested, but otherwise great work ... thanks! I'll merge this once the fix is made
| if (parameter.HasDefault && parameter.IsOptional && parameter.HasConstant) | ||
| { | ||
| buf.AppendFormat(" = {0}", MDocUpdater.MakeAttributesValueString(parameter.Constant, parameter.ParameterType)); | ||
| var paramterValue = MDocUpdater.MakeAttributesValueString(parameter.Constant, parameter.ParameterType); |
Member
There was a problem hiding this comment.
fix spelling of parameterValue
joelmartinez
approved these changes
May 27, 2020
joelmartinez
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Fix VB default value for class parameters bug https://ceapex.visualstudio.com/Engineering/_workitems/edit/221125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.