Attached Properties in WinRT missing#509
Merged
joelmartinez merged 1 commit intomono:developfrom Jul 28, 2020
Merged
Conversation
joelmartinez
requested changes
Jul 27, 2020
Member
joelmartinez
left a comment
joelmartinez
left a comment
There was a problem hiding this comment.
This looks great ... however I'd like to see some unit tests added here:
https://github.com/mono/api-doc-tools/blob/master/mdoc/mdoc.Test/Enumeration/AttachedEntityTests.cs
The unit tests should exercise these code paths and show that they'll return the expected values.
maopeixia
force-pushed
the
mpx-mdoc-1.0.2.2
branch
from
607ff4f to
30100de
Compare
joelmartinez
pushed a commit
that referenced
this pull request
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work item : https://ceapex.visualstudio.com/Engineering/_workitems/edit/211066