Skip to content

Fix Recursion for C# Formatter for ValueTuple#744

Merged
davidle-ms merged 5 commits intodevelopfrom
ledavi/fix-arg-error-valuetuple
Apr 27, 2026
Merged

Fix Recursion for C# Formatter for ValueTuple#744
davidle-ms merged 5 commits intodevelopfrom
ledavi/fix-arg-error-valuetuple

Conversation

@davidle-ms
Copy link
Copy Markdown
Collaborator

@davidle-ms davidle-ms commented Apr 24, 2026 •
edited
Loading

Resolves #11939.

Summary:

  • Fixed C# Formatter to correctly address System.ValueTuple nested ValueTuple structure, where there are more than 7 required fields, it takes the recursive structure: System.ValueTuple<T1, ..., T7, TRest>
  • Added unit test cases to validate this change
  • Tested this locally with System.ValueTuple.dll, comparing the generated xmls before and after the change. Change in xml file is as expected.

@xmdanni
Copy link
Copy Markdown
Collaborator

xmdanni commented Apr 24, 2026

https://dev.azure.com/ceapex/Engineering/_build/results?buildId=2517865

@davidle-ms
Copy link
Copy Markdown
Collaborator Author

davidle-ms commented Apr 26, 2026

@dotnet-policy-service agree company="Microsoft"

@xmdanni
Copy link
Copy Markdown
Collaborator

xmdanni commented Apr 26, 2026

https://dev.azure.com/ceapex/Engineering/_build/results?buildId=2521001

@huangmin-ms
Copy link
Copy Markdown
Collaborator

huangmin-ms commented Apr 27, 2026

@davidle-ms Could you also add unit tests in FormatterTest to verify the change?

@xmdanni
Copy link
Copy Markdown
Collaborator

xmdanni commented Apr 27, 2026

https://dev.azure.com/ceapex/Engineering/_build/results?buildId=2521293

@davidle-ms
Copy link
Copy Markdown
Collaborator Author

davidle-ms commented Apr 27, 2026

@davidle-ms Could you also add unit tests in FormatterTest to verify the change?

Added.

huangmin-ms
huangmin-ms reviewed Apr 27, 2026
View reviewed changes
Comment thread mdoc/Mono.Documentation/Updater/Formatters/CSharpFullMemberFormatter.cs Outdated
@xmdanni
Copy link
Copy Markdown
Collaborator

xmdanni commented Apr 27, 2026

https://dev.azure.com/ceapex/Engineering/_build/results?buildId=2521400

@huangmin-ms
Copy link
Copy Markdown
Collaborator

huangmin-ms commented Apr 27, 2026

you can also update the version from 5.9.6 to 5.9.7 in this PR. Code search results

@xmdanni
Copy link
Copy Markdown
Collaborator

xmdanni commented Apr 27, 2026

https://dev.azure.com/ceapex/Engineering/_build/results?buildId=2521424

@davidle-ms
Copy link
Copy Markdown
Collaborator Author

davidle-ms commented Apr 27, 2026

you can also update the version from 5.9.6 to 5.9.7 in this PR. Code search results

Updated

@davidle-ms davidle-ms merged commit 9f56244 into develop Apr 27, 2026
2 checks passed
davidle-ms added a commit that referenced this pull request Apr 27, 2026
@davidle-ms
Fix ValueTuple Formatting Error for C# Formatter (#744) (#745)
a3bdc18 
* fix: recursion with c# formatter for valuetuple

* docs: add comment to clearly explain change

* test: add test cases for method signature for valuetuple

* chore: fix unnecessary loop change

* chore: update version to 5.9.7
@davidle-ms davidle-ms deleted the ledavi/fix-arg-error-valuetuple branch April 27, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huangmin-ms huangmin-ms huangmin-ms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return type of ValueTuple.Create with 8 arguments is rendered incorrectly

3 participants

@davidle-ms @xmdanni @huangmin-ms