This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Improve clipboard ring display in toolbox #5746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Failure appears to be unrelated |
Therzok
reviewed
Aug 27, 2018
|
|
||
| clipboardRing.Add (newNode ?? CreateClipboardToolboxItem (text)); | ||
|
|
||
| while (clipboardRing.Count > clipboardRingSize) { |
Contributor
There was a problem hiding this comment.
int overflow = clipboardRing.Count - clipboardRingSize;
if (overflow > 0) {
clipboardRing.RemoveRange (0, overflow);
}
Contributor
Author
There was a problem hiding this comment.
This is old code, but good point
Therzok
reviewed
Aug 27, 2018
| var item = new ClipboardToolboxNode (text); | ||
|
|
||
| string [] lines = text.Split ('\n'); | ||
| for (int i = 0; i < 3 && i < lines.Length; i++) { |
Contributor
There was a problem hiding this comment.
Use a reusable stringbuilder from the cache to build the description?
Contributor
Author
There was a problem hiding this comment.
Ah, old code but this is redundant now since I added the custom tooltip
mhutch
force-pushed
the
clipboard-ring-toolbox-cleanup
branch
from
d3087e0 to
2d5606d
Compare
mhutch
force-pushed
the
clipboard-ring-toolbox-cleanup
branch
2 times, most recently
from
22caba1 to
317c37b
Compare
The toolbox ellipsizes now, so this code no longer needs to. Also reduce allocations.
Apply feedback from @Therzok Remove redundant code, and use a more efficient overflow removal (even though it should never be needed)
mhutch
force-pushed
the
clipboard-ring-toolbox-cleanup
branch
from
317c37b to
5b7d0c1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5709. Item titles are no longer ellipsized to 16 chars, and the tooltip shows a decent sized snippet.